Looks good. Maybe worn just a little bit too high, but if it feels right there, keep it there. The top-of-the-knee length is good, even if it should probably not be shorter. The white socks? You haven’t asked; To my opinion they in general look well with dominating red tartans, and with shoes on the impression shall be much better.