Yep, I've seen lots of pictures of vintage kilts with buttons sewn in for braces. But I can't say I've ever seen any vintage pictures where the braces were worn visibly. I'd be interested in seeing any such pictures if they're out there. Otherwise, I have to believe that it was proper to wear the braces only under a waistcoat/jacket/etc.