Looks good. I have also recycled belts that way (and purse shoulder straps).

You might turn the clips over so the sharp edges are against the back of the sporran instead of against your kilt apron.