I am about to undertake the challenge of making kilt pins for my groomsmen. I was just curious if anyone else routinely does this, and how they go about it.

From what I've seen, almost anything can serve as a kilt pin, so long as it's decorative, appropriate and has a little weight to it. This should be an interesting experiment!